Re: [libvirt] [PATCH 4/4] qemu: Obtain reference on monConfig

2018-04-09 Thread Marc Hartmayer
On Mon, Apr 09, 2018 at 04:25 PM +0200, Marc Hartmayer wrote: > On Fri, Apr 06, 2018 at 06:53 PM +0200, John Ferlan > wrote: >> Because we allow a QEMU_JOB_DESTROY to occur while we're starting >> up and we drop the @vm lock prior to qemuMonitorOpen, it's possible >> that a domain destroy opera

Re: [libvirt] [PATCH 4/4] qemu: Obtain reference on monConfig

2018-04-09 Thread Marc Hartmayer
On Fri, Apr 06, 2018 at 06:53 PM +0200, John Ferlan wrote: > Because we allow a QEMU_JOB_DESTROY to occur while we're starting > up and we drop the @vm lock prior to qemuMonitorOpen, it's possible > that a domain destroy operation "wins" the race, calls qemuProcessStop > which will free and reinit

[libvirt] [PATCH 4/4] qemu: Obtain reference on monConfig

2018-04-06 Thread John Ferlan
Because we allow a QEMU_JOB_DESTROY to occur while we're starting up and we drop the @vm lock prior to qemuMonitorOpen, it's possible that a domain destroy operation "wins" the race, calls qemuProcessStop which will free and reinitialize priv->monConfig. Depending on the exact timing either qemuMon