Re: [libvirt] [PATCH 4/4] qemu: command: wire up usage of q35/ich9 disable s3/s4

2016-01-10 Thread Martin Kletzander
On Sun, Jan 10, 2016 at 03:27:12PM -0500, Cole Robinson wrote: On 01/10/2016 04:54 AM, Martin Kletzander wrote: On Sat, Jan 09, 2016 at 04:32:23PM -0500, Cole Robinson wrote: If the q35 specific disable s3/s4 setting isn't disabled, fallback to this reads weirdly, maybe you meant "supported"

Re: [libvirt] [PATCH 4/4] qemu: command: wire up usage of q35/ich9 disable s3/s4

2016-01-10 Thread Martin Kletzander
On Sat, Jan 09, 2016 at 04:32:23PM -0500, Cole Robinson wrote: If the q35 specific disable s3/s4 setting isn't disabled, fallback to this reads weirdly, maybe you meant "supported" instead of "disabled"? specifying the PIIX setting, which is the previous behavior. It doesn't have any effect,

Re: [libvirt] [PATCH 4/4] qemu: command: wire up usage of q35/ich9 disable s3/s4

2016-01-10 Thread Cole Robinson
On 01/10/2016 04:54 AM, Martin Kletzander wrote: > On Sat, Jan 09, 2016 at 04:32:23PM -0500, Cole Robinson wrote: >> If the q35 specific disable s3/s4 setting isn't disabled, fallback to > > this reads weirdly, maybe you meant "supported" instead of "disabled"? > Yeah, I meant supported. Fixed

[libvirt] [PATCH 4/4] qemu: command: wire up usage of q35/ich9 disable s3/s4

2016-01-09 Thread Cole Robinson
If the q35 specific disable s3/s4 setting isn't disabled, fallback to specifying the PIIX setting, which is the previous behavior. It doesn't have any effect, but qemu will just warn about it rather than error: qemu-system-x86_64: Warning: global PIIX4_PM.disable_s3=1 not used qemu-system-x86_64: