Re: [libvirt] [PATCH 4/4] qemu: hotplug: Merge virtio and non-virtio disk unplug code

2019-03-15 Thread Ján Tomko
On Fri, Mar 15, 2019 at 03:44:58PM +0100, Peter Krempa wrote: The functions do basically exactly the same thing modulo few checks. In case of virtio disks we check that the device is not multifunction as that can't be unplugged at once. In case of USB and SCSI disks we checked that no active

[libvirt] [PATCH 4/4] qemu: hotplug: Merge virtio and non-virtio disk unplug code

2019-03-15 Thread Peter Krempa
The functions do basically exactly the same thing modulo few checks. In case of virtio disks we check that the device is not multifunction as that can't be unplugged at once. In case of USB and SCSI disks we checked that no active block job is running. The check for running blockjobs should have