Re: [libvirt] [PATCH 4/4] util: fix removal of callbacks in virCloseCallbacksRun

2015-04-07 Thread Ján Tomko
On Mon, Mar 30, 2015 at 01:41:01PM +1100, Michael Chapman wrote: The close callbacks hash are keyed by a UUID-string, but virCloseCallbacksRun was attempting to remove them by raw UUID. This patch ensures the callback entries are removed by UUID-string as well. This bug could cause problems

Re: [libvirt] [PATCH 4/4] util: fix removal of callbacks in virCloseCallbacksRun

2015-04-07 Thread Michael Chapman
On Tue, 7 Apr 2015, Ján Tomko wrote: On Mon, Mar 30, 2015 at 01:41:01PM +1100, Michael Chapman wrote: The close callbacks hash are keyed by a UUID-string, but virCloseCallbacksRun was attempting to remove them by raw UUID. This patch ensures the callback entries are removed by UUID-string as

[libvirt] [PATCH 4/4] util: fix removal of callbacks in virCloseCallbacksRun

2015-03-29 Thread Michael Chapman
The close callbacks hash are keyed by a UUID-string, but virCloseCallbacksRun was attempting to remove them by raw UUID. This patch ensures the callback entries are removed by UUID-string as well. This bug could cause problems when guest migrations were abnormally aborted: # timeout --signal