Re: [libvirt] [PATCH 4/5] phyp: Fix too small buffer allocation in phypAttachDevice

2011-04-14 Thread Matthias Bolte
2011/4/14 Eric Blake : > On 04/14/2011 06:00 AM, Matthias Bolte wrote: >>>  ACK, we just need to make sure contains_specialcharacters() and >>> escape_specialcharacters() don't diverge on the charater set. Maybe >>> add a comment in escape_specialcharacters() to this effect. >>> >>> Daniel >>> >> >

Re: [libvirt] [PATCH 4/5] phyp: Fix too small buffer allocation in phypAttachDevice

2011-04-14 Thread Eric Blake
On 04/14/2011 06:00 AM, Matthias Bolte wrote: >> ACK, we just need to make sure contains_specialcharacters() and >> escape_specialcharacters() don't diverge on the charater set. Maybe >> add a comment in escape_specialcharacters() to this effect. >> >> Daniel >> > > I just moved the character set

Re: [libvirt] [PATCH 4/5] phyp: Fix too small buffer allocation in phypAttachDevice

2011-04-14 Thread Matthias Bolte
2011/4/11 Daniel Veillard : > On Sat, Apr 09, 2011 at 11:59:10AM +0200, Matthias Bolte wrote: >> sizeof(domain->name) is the wrong thing. Instead of using strdup here >> rewrite escape_specialcharacters to allocate the buffer itself. >> >> Add a contains_specialcharacters to be used in phypOpen, as

Re: [libvirt] [PATCH 4/5] phyp: Fix too small buffer allocation in phypAttachDevice

2011-04-10 Thread Daniel Veillard
On Sat, Apr 09, 2011 at 11:59:10AM +0200, Matthias Bolte wrote: > sizeof(domain->name) is the wrong thing. Instead of using strdup here > rewrite escape_specialcharacters to allocate the buffer itself. > > Add a contains_specialcharacters to be used in phypOpen, as phypOpen is > not interested in

[libvirt] [PATCH 4/5] phyp: Fix too small buffer allocation in phypAttachDevice

2011-04-09 Thread Matthias Bolte
sizeof(domain->name) is the wrong thing. Instead of using strdup here rewrite escape_specialcharacters to allocate the buffer itself. Add a contains_specialcharacters to be used in phypOpen, as phypOpen is not interested in the escaped version. --- src/phyp/phyp_driver.c | 90 ++