Re: [libvirt] [PATCH 4/5] qemu: implement virConnectListAllDomains() for qemu driver

2012-05-24 Thread Peter Krempa
On 05/24/2012 03:37 PM, Daniel P. Berrange wrote: On Thu, May 24, 2012 at 03:22:28PM +0200, Michal Privoznik wrote: On 24.05.2012 14:14, Daniel P. Berrange wrote: On Thu, May 24, 2012 at 05:46:51AM -0600, Eric Blake wrote: On 05/20/2012 09:56 AM, Peter Krempa wrote: This patch adds a basic im

Re: [libvirt] [PATCH 4/5] qemu: implement virConnectListAllDomains() for qemu driver

2012-05-24 Thread Daniel P. Berrange
On Thu, May 24, 2012 at 03:22:28PM +0200, Michal Privoznik wrote: > On 24.05.2012 14:14, Daniel P. Berrange wrote: > > On Thu, May 24, 2012 at 05:46:51AM -0600, Eric Blake wrote: > >> On 05/20/2012 09:56 AM, Peter Krempa wrote: > >>> This patch adds a basic implementation of the listing code for >

Re: [libvirt] [PATCH 4/5] qemu: implement virConnectListAllDomains() for qemu driver

2012-05-24 Thread Michal Privoznik
On 24.05.2012 14:14, Daniel P. Berrange wrote: > On Thu, May 24, 2012 at 05:46:51AM -0600, Eric Blake wrote: >> On 05/20/2012 09:56 AM, Peter Krempa wrote: >>> This patch adds a basic implementation of the listing code for >>> virConnectListAllDomains() to qemu driver. The listing code does >>> not

Re: [libvirt] [PATCH 4/5] qemu: implement virConnectListAllDomains() for qemu driver

2012-05-24 Thread Eric Blake
On 05/24/2012 06:14 AM, Daniel P. Berrange wrote: >> I just realized: Since we are executing this under the driver lock, and >> no VM can change state until we let go of the driver lock, it is not >> necessary to lock vms in this loop. That will help things go faster in >> computing the list. >

Re: [libvirt] [PATCH 4/5] qemu: implement virConnectListAllDomains() for qemu driver

2012-05-24 Thread Daniel P. Berrange
On Thu, May 24, 2012 at 05:46:51AM -0600, Eric Blake wrote: > On 05/20/2012 09:56 AM, Peter Krempa wrote: > > This patch adds a basic implementation of the listing code for > > virConnectListAllDomains() to qemu driver. The listing code does > > not support any filtering flags yet, but they may be

Re: [libvirt] [PATCH 4/5] qemu: implement virConnectListAllDomains() for qemu driver

2012-05-24 Thread Eric Blake
On 05/20/2012 09:56 AM, Peter Krempa wrote: > This patch adds a basic implementation of the listing code for > virConnectListAllDomains() to qemu driver. The listing code does > not support any filtering flags yet, but they may be easily added > later. > --- > src/qemu/qemu_driver.c | 97 >

Re: [libvirt] [PATCH 4/5] qemu: implement virConnectListAllDomains() for qemu driver

2012-05-21 Thread Eric Blake
On 05/20/2012 09:56 AM, Peter Krempa wrote: > This patch adds a basic implementation of the listing code for > virConnectListAllDomains() to qemu driver. The listing code does > not support any filtering flags yet, but they may be easily added > later. We need to also cover all the other drivers;

[libvirt] [PATCH 4/5] qemu: implement virConnectListAllDomains() for qemu driver

2012-05-20 Thread Peter Krempa
This patch adds a basic implementation of the listing code for virConnectListAllDomains() to qemu driver. The listing code does not support any filtering flags yet, but they may be easily added later. --- src/qemu/qemu_driver.c | 97 1 files chang