Re: [libvirt] [PATCH 4/6] conf: Move virDomainPCIAddressAsString() to device_conf

2018-08-31 Thread Andrea Bolognani
On Fri, 2018-08-31 at 15:29 +0100, Daniel P. Berrangé wrote: > On Fri, Aug 31, 2018 at 04:25:25PM +0200, Andrea Bolognani wrote: > > On Fri, 2018-08-31 at 15:05 +0100, Daniel P. Berrangé wrote: > > > This should really be in src/util/virpci.{c,h}, since that's where the > > >

Re: [libvirt] [PATCH 4/6] conf: Move virDomainPCIAddressAsString() to device_conf

2018-08-31 Thread Daniel P . Berrangé
On Fri, Aug 31, 2018 at 04:25:25PM +0200, Andrea Bolognani wrote: > On Fri, 2018-08-31 at 15:05 +0100, Daniel P. Berrangé wrote: > > On Fri, Aug 31, 2018 at 04:00:45PM +0200, Andrea Bolognani wrote: > > > Unfortunately, even after this change functions > > > handling virPCIDeviceAddress are split

Re: [libvirt] [PATCH 4/6] conf: Move virDomainPCIAddressAsString() to device_conf

2018-08-31 Thread Andrea Bolognani
On Fri, 2018-08-31 at 15:05 +0100, Daniel P. Berrangé wrote: > On Fri, Aug 31, 2018 at 04:00:45PM +0200, Andrea Bolognani wrote: > > Unfortunately, even after this change functions > > handling virPCIDeviceAddress are split pretty much > > evenly between conf/device_conf and utils/virpci: > >

Re: [libvirt] [PATCH 4/6] conf: Move virDomainPCIAddressAsString() to device_conf

2018-08-31 Thread Daniel P . Berrangé
On Fri, Aug 31, 2018 at 04:00:45PM +0200, Andrea Bolognani wrote: > It's a better fit than domain_conf. > > Unfortunately, even after this change functions > handling virPCIDeviceAddress are split pretty much > evenly between conf/device_conf and utils/virpci: > ideally everything would be moved

[libvirt] [PATCH 4/6] conf: Move virDomainPCIAddressAsString() to device_conf

2018-08-31 Thread Andrea Bolognani
It's a better fit than domain_conf. Unfortunately, even after this change functions handling virPCIDeviceAddress are split pretty much evenly between conf/device_conf and utils/virpci: ideally everything would be moved to the former, including the struct declaration itself, and all the names