Re: [libvirt] [PATCH 4/6] conf: Parse and format the new XML

2013-01-03 Thread Osier Yang
On 2013年01月04日 08:21, Eric Blake wrote: On 01/02/2013 07:37 AM, Osier Yang wrote: Like "rawio", "sgio" is only allowed for block disk of device type "lun". It doesn't default disk->sgio to "filtered" when parsing, as it won't be able to distinguish explicitly requested "filtered" and a default

Re: [libvirt] [PATCH 4/6] conf: Parse and format the new XML

2013-01-03 Thread Eric Blake
On 01/02/2013 07:37 AM, Osier Yang wrote: > Like "rawio", "sgio" is only allowed for block disk of device > type "lun". > > It doesn't default disk->sgio to "filtered" when parsing, as > it won't be able to distinguish explicitly requested "filtered" > and a default "filtered" in driver then. We h

[libvirt] [PATCH 4/6] conf: Parse and format the new XML

2013-01-02 Thread Osier Yang
Like "rawio", "sgio" is only allowed for block disk of device type "lun". It doesn't default disk->sgio to "filtered" when parsing, as it won't be able to distinguish explicitly requested "filtered" and a default "filtered" in driver then. We have to error out for explicit request when the kernel

[libvirt] [PATCH 4/6] conf: Parse and format the new XML

2012-12-18 Thread Osier Yang
Like "rawio", "sgio" is only allowed for block disk of device type "lun". It doesn't default disk->sgio to "filtered" when parsing, as it won't be able to distinguish explicitly requested "filtered" and a default "filtered" in driver then. We have to error out for explicit request when the kernel