Re: [libvirt] [PATCH 4/6] conf: relocate rombar and boot order parse/format

2012-01-30 Thread Laine Stump
On 01/25/2012 10:02 PM, Eric Blake wrote: On 01/25/2012 09:58 AM, Laine Stump wrote: Since these two items are now in the virDomainDeviceInfo struct, it makes sense to parse/format them in the functions written to parse/format that structure. Not all types of devices allow them, so two internal

[libvirt] [PATCH 4/6] conf: relocate rombar and boot order parse/format

2012-01-25 Thread Laine Stump
Since these two items are now in the virDomainDeviceInfo struct, it makes sense to parse/format them in the functions written to parse/format that structure. Not all types of devices allow them, so two internal flags are added to indicate when it is appropriate to do so. I was lucky - only one

Re: [libvirt] [PATCH 4/6] conf: relocate rombar and boot order parse/format

2012-01-25 Thread Eric Blake
On 01/25/2012 09:58 AM, Laine Stump wrote: Since these two items are now in the virDomainDeviceInfo struct, it makes sense to parse/format them in the functions written to parse/format that structure. Not all types of devices allow them, so two internal flags are added to indicate when it is