Re: [libvirt] [PATCH 4/8] Remove all uses of virshReportError except "vshError".

2010-07-19 Thread Chris Lalancette
On 07/17/10 - 06:07:00PM, Matthias Bolte wrote: > For example this one. I tested it with and without this patch. > > Without this patch we get > > virsh # snapshot-create test1 this-file-does-not-exist.xml > error: Failed to open file 'this-file-does-not-exist.xml': No such > file or directory >

Re: [libvirt] [PATCH 4/8] Remove all uses of virshReportError except "vshError".

2010-07-17 Thread Matthias Bolte
2010/7/8 Chris Lalancette : > With the current virsh code, error reporting is a bit fragile > because the reporting is decoupled from the place where the > error occurred.  There are two places where this can be a problem: > > 1)  In utility functions that don't properly dispatch errors > like the

[libvirt] [PATCH 4/8] Remove all uses of virshReportError except "vshError".

2010-07-08 Thread Chris Lalancette
With the current virsh code, error reporting is a bit fragile because the reporting is decoupled from the place where the error occurred. There are two places where this can be a problem: 1) In utility functions that don't properly dispatch errors like the main API functions do. In this case, t