Re: [libvirt] [PATCH 4/8] conf: Allow NULL for virDomainDeviceInfoCallback

2019-05-22 Thread Andrea Bolognani
On Wed, 2019-05-22 at 16:12 +0200, Ján Tomko wrote: > On Wed, May 22, 2019 at 03:36:59PM +0200, Andrea Bolognani wrote: > > I don't much like the idea of adding a separate function that does > > almost the same thing but not quite, because that will ultimately > > result in the same situation we ha

Re: [libvirt] [PATCH 4/8] conf: Allow NULL for virDomainDeviceInfoCallback

2019-05-22 Thread Ján Tomko
On Wed, May 22, 2019 at 03:36:59PM +0200, Andrea Bolognani wrote: On Tue, 2019-05-21 at 16:28 +0200, Ján Tomko wrote: On Mon, May 20, 2019 at 03:24:06PM +0200, Andrea Bolognani wrote: > On Mon, 2019-05-20 at 14:59 +0200, Ján Tomko wrote: > > Of course, there is a huge overlap between iterating o

Re: [libvirt] [PATCH 4/8] conf: Allow NULL for virDomainDeviceInfoCallback

2019-05-22 Thread Andrea Bolognani
On Tue, 2019-05-21 at 16:28 +0200, Ján Tomko wrote: > On Mon, May 20, 2019 at 03:24:06PM +0200, Andrea Bolognani wrote: > > On Mon, 2019-05-20 at 14:59 +0200, Ján Tomko wrote: > > > Of course, there is a huge overlap between iterating over all devices > > > and just those with an info, but since th

Re: [libvirt] [PATCH 4/8] conf: Allow NULL for virDomainDeviceInfoCallback

2019-05-21 Thread Ján Tomko
On Mon, May 20, 2019 at 03:24:06PM +0200, Andrea Bolognani wrote: On Mon, 2019-05-20 at 14:59 +0200, Ján Tomko wrote: On Mon, May 20, 2019 at 01:37:49PM +0200, Andrea Bolognani wrote: > The virDomainDeviceInfoIterate() function was initially > written with the expectation that all devices would

Re: [libvirt] [PATCH 4/8] conf: Allow NULL for virDomainDeviceInfoCallback

2019-05-20 Thread Andrea Bolognani
On Mon, 2019-05-20 at 14:59 +0200, Ján Tomko wrote: > On Mon, May 20, 2019 at 01:37:49PM +0200, Andrea Bolognani wrote: > > The virDomainDeviceInfoIterate() function was initially > > written with the expectation that all devices would embed a > > virDomainDeviceInfo, and thus the user-provided cal

Re: [libvirt] [PATCH 4/8] conf: Allow NULL for virDomainDeviceInfoCallback

2019-05-20 Thread Ján Tomko
On Mon, May 20, 2019 at 01:37:49PM +0200, Andrea Bolognani wrote: The virDomainDeviceInfoIterate() function was initially written with the expectation that all devices would embed a virDomainDeviceInfo, and thus the user-provided callback would never be passed NULL; however, that doesn't really r

[libvirt] [PATCH 4/8] conf: Allow NULL for virDomainDeviceInfoCallback

2019-05-20 Thread Andrea Bolognani
The virDomainDeviceInfoIterate() function was initially written with the expectation that all devices would embed a virDomainDeviceInfo, and thus the user-provided callback would never be passed NULL; however, that doesn't really represent reality, as multiple devices don't have any virDomainDevice