Re: [libvirt] [PATCH 4/8] qemu: Don't repeat virDomainObjEndAPI in qemuDomainBlockPull

2019-09-27 Thread Peter Krempa
On Fri, Sep 27, 2019 at 07:48:55 -0500, Eric Blake wrote: > On 9/27/19 1:33 AM, Peter Krempa wrote: > > On Thu, Sep 26, 2019 at 17:02:49 -0500, Eric Blake wrote: > > > On 9/26/19 10:51 AM, Peter Krempa wrote: > > > > Add a 'cleanup' label and use jumps as we do in other places. > > > > > > > > Sig

Re: [libvirt] [PATCH 4/8] qemu: Don't repeat virDomainObjEndAPI in qemuDomainBlockPull

2019-09-27 Thread Eric Blake
On 9/27/19 1:33 AM, Peter Krempa wrote: On Thu, Sep 26, 2019 at 17:02:49 -0500, Eric Blake wrote: On 9/26/19 10:51 AM, Peter Krempa wrote: Add a 'cleanup' label and use jumps as we do in other places. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 17 ++--- 1 file c

Re: [libvirt] [PATCH 4/8] qemu: Don't repeat virDomainObjEndAPI in qemuDomainBlockPull

2019-09-26 Thread Peter Krempa
On Thu, Sep 26, 2019 at 17:02:49 -0500, Eric Blake wrote: > On 9/26/19 10:51 AM, Peter Krempa wrote: > > Add a 'cleanup' label and use jumps as we do in other places. > > > > Signed-off-by: Peter Krempa > > --- > > src/qemu/qemu_driver.c | 17 ++--- > > 1 file changed, 10 insertion

Re: [libvirt] [PATCH 4/8] qemu: Don't repeat virDomainObjEndAPI in qemuDomainBlockPull

2019-09-26 Thread Eric Blake
On 9/26/19 10:51 AM, Peter Krempa wrote: Add a 'cleanup' label and use jumps as we do in other places. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) + cleanup: +virDomainObjEndAPI(&vm); +return ret;

[libvirt] [PATCH 4/8] qemu: Don't repeat virDomainObjEndAPI in qemuDomainBlockPull

2019-09-26 Thread Peter Krempa
Add a 'cleanup' label and use jumps as we do in other places. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 71503898e4..3ad1699eb1 100644 --- a/sr