Re: [libvirt] [PATCH 4/8] snapshot: Add VIR_DOMAIN_SNAPSHOT_CREATE_VALIDATE flag

2019-07-09 Thread Peter Krempa
On Mon, Jul 08, 2019 at 22:12:38 -0500, Eric Blake wrote: > On 7/8/19 2:56 AM, Peter Krempa wrote: > > On Fri, Jul 05, 2019 at 23:37:31 -0500, Eric Blake wrote: > >> We've been doing a terrible job of performing XML validation in our > >> various API that parse XML with a corresponding schema (we

Re: [libvirt] [PATCH 4/8] snapshot: Add VIR_DOMAIN_SNAPSHOT_CREATE_VALIDATE flag

2019-07-08 Thread Eric Blake
On 7/8/19 2:56 AM, Peter Krempa wrote: > On Fri, Jul 05, 2019 at 23:37:31 -0500, Eric Blake wrote: >> We've been doing a terrible job of performing XML validation in our >> various API that parse XML with a corresponding schema (we started >> with domains back in commit dd69a14f, v1.2.12, but

Re: [libvirt] [PATCH 4/8] snapshot: Add VIR_DOMAIN_SNAPSHOT_CREATE_VALIDATE flag

2019-07-08 Thread Peter Krempa
On Fri, Jul 05, 2019 at 23:37:31 -0500, Eric Blake wrote: > We've been doing a terrible job of performing XML validation in our > various API that parse XML with a corresponding schema (we started > with domains back in commit dd69a14f, v1.2.12, but didn't catch all > domain-related APIs, and

[libvirt] [PATCH 4/8] snapshot: Add VIR_DOMAIN_SNAPSHOT_CREATE_VALIDATE flag

2019-07-05 Thread Eric Blake
We've been doing a terrible job of performing XML validation in our various API that parse XML with a corresponding schema (we started with domains back in commit dd69a14f, v1.2.12, but didn't catch all domain-related APIs, and didn't cover other XMLM). New APIs (like checkpoints) should do the