Re: [libvirt] [PATCH 4/8] travis: Split building command

2017-09-14 Thread Martin Kletzander
On Thu, Sep 14, 2017 at 05:10:24PM +0200, Andrea Bolognani wrote: On Thu, 2017-09-14 at 16:49 +0200, Martin Kletzander wrote: > So I'm on the fence about this patch - I'd have a slight preference for > existing behaviour of failing fast to keep errors at the end of the log I, personally, would

Re: [libvirt] [PATCH 4/8] travis: Split building command

2017-09-14 Thread Martin Kletzander
On Thu, Sep 14, 2017 at 02:48:06PM +0100, Daniel P. Berrange wrote: On Thu, Sep 14, 2017 at 03:09:04PM +0200, Andrea Bolognani wrote: The build will fail if any of the commands fail, but this way we might catch more errors in a single run. Signed-off-by: Andrea Bolognani --- .travis.yml | 4 +

Re: [libvirt] [PATCH 4/8] travis: Split building command

2017-09-14 Thread Andrea Bolognani
On Thu, 2017-09-14 at 16:49 +0200, Martin Kletzander wrote: > > So I'm on the fence about this patch - I'd have a slight preference for > > existing behaviour of failing fast to keep errors at the end of the log > > I, personally, would go with: > > script: > - make -j3 check > - make -j3 synta

Re: [libvirt] [PATCH 4/8] travis: Split building command

2017-09-14 Thread Andrea Bolognani
On Thu, 2017-09-14 at 14:48 +0100, Daniel P. Berrange wrote: > > script: > > - - make -j3 && make -j3 syntax-check && make -j3 check > > + - make -j3 > > + - make -j3 syntax-check > > + - make -j3 check > > > > # Environments here are run in addition to the main environment defined > > abov

Re: [libvirt] [PATCH 4/8] travis: Split building command

2017-09-14 Thread Daniel P. Berrange
On Thu, Sep 14, 2017 at 04:45:30PM +0200, Andrea Bolognani wrote: > On Thu, 2017-09-14 at 14:48 +0100, Daniel P. Berrange wrote: > > > script: > > > - - make -j3 && make -j3 syntax-check && make -j3 check > > > + - make -j3 > > > + - make -j3 syntax-check > > > + - make -j3 check > > > > > >

Re: [libvirt] [PATCH 4/8] travis: Split building command

2017-09-14 Thread Daniel P. Berrange
On Thu, Sep 14, 2017 at 03:09:04PM +0200, Andrea Bolognani wrote: > The build will fail if any of the commands fail, but this way we > might catch more errors in a single run. > > Signed-off-by: Andrea Bolognani > --- > .travis.yml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >

[libvirt] [PATCH 4/8] travis: Split building command

2017-09-14 Thread Andrea Bolognani
The build will fail if any of the commands fail, but this way we might catch more errors in a single run. Signed-off-by: Andrea Bolognani --- .travis.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index ba8ff49a1..c2526bc6d 100644 --- a/.trav