Re: [libvirt] [PATCH 4/9] qemu: blockjob: Register disk->mirror with a job only when required

2019-07-25 Thread Peter Krempa
On Wed, Jul 24, 2019 at 17:02:46 -0500, Eric Blake wrote: > On 7/24/19 4:07 PM, Peter Krempa wrote: > > Commit job for example references existing storage in the > > subelement thus tracking it separately could lead into problems. > > Grammar is hard to parse, maybe: > > The subelement is used

Re: [libvirt] [PATCH 4/9] qemu: blockjob: Register disk->mirror with a job only when required

2019-07-24 Thread Eric Blake
On 7/24/19 4:07 PM, Peter Krempa wrote: > Commit job for example references existing storage in the > subelement thus tracking it separately could lead into problems. Grammar is hard to parse, maybe: The subelement is used in two ways: in a commit job to point to existing storage, and in a

[libvirt] [PATCH 4/9] qemu: blockjob: Register disk->mirror with a job only when required

2019-07-24 Thread Peter Krempa
Commit job for example references existing storage in the subelement thus tracking it separately could lead into problems. This patch introduces qemuBlockJobDiskRegisterMirror which registers the mirror chain separately only for job which require it. This also comes with remembering that in the