Re: [libvirt] [PATCH 5/5] qemuDomainDetachDeviceUnlink: Don't unlink files we haven't created

2017-05-03 Thread Cedric Bosdonnat
On Fri, 2017-04-28 at 13:22 +0200, Michal Privoznik wrote: > Even though there are several checks before calling this function > and for some scenarios we don't call it at all (e.g. on disk hot > unplug), it may be possible to sneak in some weird files (e.g. if > domain would have RNG with

[libvirt] [PATCH 5/5] qemuDomainDetachDeviceUnlink: Don't unlink files we haven't created

2017-04-28 Thread Michal Privoznik
Even though there are several checks before calling this function and for some scenarios we don't call it at all (e.g. on disk hot unplug), it may be possible to sneak in some weird files (e.g. if domain would have RNG with /dev/shm/some_file as its backend). No matter how improbable, we shouldn't