Re: [libvirt] [PATCH 5/5] security: Remove unnecessary checks for mgr == NULL

2013-02-14 Thread Peter Krempa
On 02/14/13 17:42, John Ferlan wrote: Coverity found the DACGenLabel was checking for mgr == NULL after a possible dereference; however, in order to get into the function the virSecurityManagerGenLabel would have already dereferenced sec_managers[i] so the check was unnecessary. Same check is mad

[libvirt] [PATCH 5/5] security: Remove unnecessary checks for mgr == NULL

2013-02-14 Thread John Ferlan
Coverity found the DACGenLabel was checking for mgr == NULL after a possible dereference; however, in order to get into the function the virSecurityManagerGenLabel would have already dereferenced sec_managers[i] so the check was unnecessary. Same check is made in SELinuxGenSecurityLabel. --- src/s