Re: [libvirt] [PATCH 5/5] setmem: add the new options to virsh setmem command

2011-03-10 Thread Eric Blake
On 03/10/2011 12:44 AM, Paolo Bonzini wrote: On 03/09/2011 04:59 PM, Daniel P. Berrange wrote: +if (!flags) { +if (virDomainSetMemory(dom, kilobytes) != 0) { +ret = FALSE; +} Indentation went a little bit wrong here. Also '!flags' could in fact be

Re: [libvirt] [PATCH 5/5] setmem: add the new options to virsh setmem command

2011-03-10 Thread Eric Blake
On 03/02/2011 01:13 AM, Taku Izumi wrote: This patch adds the new options (--live and --config) to virsh setmem command. The behavior of above options is the same as that of virsh setvcpus and so on. That is, when the --config option is specified, a modification is effective for the

Re: [libvirt] [PATCH 5/5] setmem: add the new options to virsh setmem command

2011-03-10 Thread Taku Izumi
At any rate, ACK as modified, and I pushed the amended series. Thanks again for your first contribution! Thank you for reviewing and correcting it. I also express my appreciation to persons who responded this thread. Thank you for Danie, Paolo, and Eric! -- Taku Izumi

Re: [libvirt] [PATCH 5/5] setmem: add the new options to virsh setmem command

2011-03-09 Thread Daniel P. Berrange
On Wed, Mar 02, 2011 at 05:13:39PM +0900, Taku Izumi wrote: This patch adds the new options (--live and --config) to virsh setmem command. The behavior of above options is the same as that of virsh setvcpus and so on. That is, when the --config option is specified, a modification is

Re: [libvirt] [PATCH 5/5] setmem: add the new options to virsh setmem command

2011-03-09 Thread Paolo Bonzini
On 03/09/2011 04:59 PM, Daniel P. Berrange wrote: +if (!flags) { + if (virDomainSetMemory(dom, kilobytes) != 0) { +ret = FALSE; + } Indentation went a little bit wrong here. Also '!flags' could in fact be '!flags || (flags == VIR_DOMAIN_MEM_LIVE)'

[libvirt] [PATCH 5/5] setmem: add the new options to virsh setmem command

2011-03-02 Thread Taku Izumi
This patch adds the new options (--live and --config) to virsh setmem command. The behavior of above options is the same as that of virsh setvcpus and so on. That is, when the --config option is specified, a modification is effective for the persistent domain. Moreover we can modify the memory