Re: [libvirt] [PATCH 5/6] libvirt: Ensure modern APIs are implemented

2019-07-09 Thread Eric Blake
On 7/9/19 4:36 AM, Daniel P. Berrangé wrote: > On Tue, Jul 09, 2019 at 11:02:03AM +0200, Peter Krempa wrote: >> On Mon, Jul 08, 2019 at 22:37:02 -0500, Eric Blake wrote: >>> As shown in recent patches, several drivers provided only an older >>> counterpart of an API, making it harder to uniformly

Re: [libvirt] [PATCH 5/6] libvirt: Ensure modern APIs are implemented

2019-07-09 Thread Daniel P . Berrangé
On Tue, Jul 09, 2019 at 11:02:03AM +0200, Peter Krempa wrote: > On Mon, Jul 08, 2019 at 22:37:02 -0500, Eric Blake wrote: > > As shown in recent patches, several drivers provided only an older > > counterpart of an API, making it harder to uniformly use the newer > > preferred API form. We can

Re: [libvirt] [PATCH 5/6] libvirt: Ensure modern APIs are implemented

2019-07-09 Thread Peter Krempa
On Mon, Jul 08, 2019 at 22:37:02 -0500, Eric Blake wrote: > As shown in recent patches, several drivers provided only an older > counterpart of an API, making it harder to uniformly use the newer > preferred API form. We can prevent future instances of this by failing > the driver at

[libvirt] [PATCH 5/6] libvirt: Ensure modern APIs are implemented

2019-07-08 Thread Eric Blake
As shown in recent patches, several drivers provided only an older counterpart of an API, making it harder to uniformly use the newer preferred API form. We can prevent future instances of this by failing the driver at initialization time if a modern API is forgotten when an older API is present.