On 06/12/2012 06:42 PM, Eric Blake wrote:
>> I really need to list this as a comment. I'll post a v2, adding
>> comments and including your improvements.
>
> Here's what I'll squash for my v2:
>
> +/* First, determine if we can use the new child listing API. */
> +if (!ctl->us
On 06/12/2012 05:27 PM, Eric Blake wrote:
> I'm off on my versioning - this was 0.9.6 and earlier.
>
>> if (from) {
>
> There's multiple things going on here:
>
> First, the valid combinations:
>
> Then the API that satisfy those combinations:
>
> I really need to list this as a commen
On 06/12/2012 06:59 AM, Peter Krempa wrote:
> On 06/12/12 14:54, Peter Krempa wrote:
>> On 06/09/12 06:34, Eric Blake wrote:
>>> This patch copies just the fallback code out of cmdSnapshotList,
>>> and keeps the snapshot objects around rather than just their
>>> name for easier manipulation. It lo
On 06/12/12 14:54, Peter Krempa wrote:
On 06/09/12 06:34, Eric Blake wrote:
This patch copies just the fallback code out of cmdSnapshotList,
and keeps the snapshot objects around rather than just their
name for easier manipulation. It looks forward to a future
patch when we add a way to list al
On 06/09/12 06:34, Eric Blake wrote:
> This patch copies just the fallback code out of cmdSnapshotList,
> and keeps the snapshot objects around rather than just their
> name for easier manipulation. It looks forward to a future
> patch when we add a way to list all snapshot objects at once,
> and
This patch copies just the fallback code out of cmdSnapshotList,
and keeps the snapshot objects around rather than just their
name for easier manipulation. It looks forward to a future
patch when we add a way to list all snapshot objects at once,
and the next patch will simplify cmdSnapshotList to
