Re: [libvirt] [PATCH 5/9] virhostdevtest: Drop most of 'cleanup' and 'out' labels

2019-08-26 Thread Ján Tomko
On Mon, Aug 12, 2019 at 01:54:21PM +0200, Michal Privoznik wrote: From: Michal Privoznik In this test there is this macro CHECK_LIST_COUNT() which checks if a list of PCI devices contains expected count. If it doesn't an error is reported and 'goto cleanup' is invoked. There's no real reason

Re: [libvirt] [PATCH 5/9] virhostdevtest: Drop most of 'cleanup' and 'out' labels

2019-08-26 Thread Ján Tomko
On Mon, Aug 12, 2019 at 01:54:21PM +0200, Michal Privoznik wrote: From: Michal Privoznik Different e-mail. In this test there is this macro CHECK_LIST_COUNT() which checks if a list of PCI devices contains expected count. If it doesn't an error is reported and 'goto cleanup' is invoked.

[libvirt] [PATCH 5/9] virhostdevtest: Drop most of 'cleanup' and 'out' labels

2019-08-12 Thread Michal Privoznik
From: Michal Privoznik In this test there is this macro CHECK_LIST_COUNT() which checks if a list of PCI devices contains expected count. If it doesn't an error is reported and 'goto cleanup' is invoked. There's no real reason for that as even since its introduction there is no cleanup done and