Re: [libvirt] [PATCH 6/7] Introduce qemuDomainMachineIsVirt

2016-05-03 Thread Andrea Bolognani
On Tue, 2016-05-03 at 13:19 +0200, Andrea Bolognani wrote: > On Tue, 2016-05-03 at 13:05 +0200, Peter Krempa wrote: > > > > > > +bool > > > +qemuDomainMachineIsVirt(const virDomainDef *def) > > > +{ > > > +return STREQ(def->os.machine, "virt") || > > > +   STRPREFIX(def->os.machine,

Re: [libvirt] [PATCH 6/7] Introduce qemuDomainMachineIsVirt

2016-05-03 Thread Andrea Bolognani
On Tue, 2016-05-03 at 13:05 +0200, Peter Krempa wrote: > > +bool > > +qemuDomainMachineIsVirt(const virDomainDef *def) > > +{ > > +return STREQ(def->os.machine, "virt") || > > +   STRPREFIX(def->os.machine, "virt-"); > > This could be transcribed as: > strcmp(def->os.machine, "virt")

Re: [libvirt] [PATCH 6/7] Introduce qemuDomainMachineIsVirt

2016-05-03 Thread Peter Krempa
On Tue, May 03, 2016 at 12:47:26 +0200, Ján Tomko wrote: > Use it everywhere except for virQEMUCapsFillDomainFeatureGICCaps. > --- > src/qemu/qemu_capabilities.c | 3 +-- > src/qemu/qemu_command.c| 3 +-- > src/qemu/qemu_domain.c | 18 +++--- >

[libvirt] [PATCH 6/7] Introduce qemuDomainMachineIsVirt

2016-05-03 Thread Ján Tomko
Use it everywhere except for virQEMUCapsFillDomainFeatureGICCaps. --- src/qemu/qemu_capabilities.c | 3 +-- src/qemu/qemu_command.c| 3 +-- src/qemu/qemu_domain.c | 18 +++--- src/qemu/qemu_domain.h | 1 + src/qemu/qemu_domain_address.c | 6 ++ 5