Re: [libvirt] [PATCH 6/7] Re-write virsh console to use streams

2010-08-23 Thread Daniel P. Berrange
On Tue, Aug 17, 2010 at 06:02:45PM +0100, Daniel P. Berrange wrote: This re-writes the 'virsh console' command so that it uses the new streams API. This lets it run remotely and/or as a non-root user. This requires that virsh be linked against the simple event loop from libvirtd in

Re: [libvirt] [PATCH 6/7] Re-write virsh console to use streams

2010-08-23 Thread Matthias Bolte
2010/8/23 Daniel P. Berrange berra...@redhat.com: On Tue, Aug 17, 2010 at 06:02:45PM +0100, Daniel P. Berrange wrote: This re-writes the 'virsh console' command so that it uses the new streams API. This lets it run remotely and/or as a non-root user. This requires that virsh be linked against

Re: [libvirt] [PATCH 6/7] Re-write virsh console to use streams

2010-08-20 Thread Daniel P. Berrange
On Thu, Aug 19, 2010 at 03:09:45PM -0600, Eric Blake wrote: On 08/17/2010 11:02 AM, Daniel P. Berrange wrote: This re-writes the 'virsh console' command so that it uses the new streams API. This lets it run remotely and/or as a non-root user. This requires that virsh be linked against the

Re: [libvirt] [PATCH 6/7] Re-write virsh console to use streams

2010-08-20 Thread Eric Blake
On 08/20/2010 03:10 AM, Daniel P. Berrange wrote: +done = write(fd, + con-streamToTerminal.data, + con-streamToTerminal.offset); Do we want to use safewrite here? All I/O in this is now done non-blocking, so don't actually want to block on

Re: [libvirt] [PATCH 6/7] Re-write virsh console to use streams

2010-08-19 Thread Eric Blake
On 08/17/2010 11:02 AM, Daniel P. Berrange wrote: This re-writes the 'virsh console' command so that it uses the new streams API. This lets it run remotely and/or as a non-root user. This requires that virsh be linked against the simple event loop from libvirtd in daemon/event.c As an added

[libvirt] [PATCH 6/7] Re-write virsh console to use streams

2010-08-17 Thread Daniel P. Berrange
This re-writes the 'virsh console' command so that it uses the new streams API. This lets it run remotely and/or as a non-root user. This requires that virsh be linked against the simple event loop from libvirtd in daemon/event.c As an added bonus, it can now connect to any console device, not