Re: [libvirt] [PATCH 6/7] Switch to filtering based on log source name instead of filename

2014-03-10 Thread Daniel P. Berrange
On Fri, Mar 07, 2014 at 11:05:28AM -0700, Eric Blake wrote: On 03/03/2014 12:18 PM, Daniel P. Berrange wrote: Both of these options have a notable performance impact, however, and it is believed that worst case behaviour where the fields are read concurrently with being written would

Re: [libvirt] [PATCH 6/7] Switch to filtering based on log source name instead of filename

2014-03-10 Thread Eric Blake
On 03/10/2014 04:18 AM, Daniel P. Berrange wrote: On Fri, Mar 07, 2014 at 11:05:28AM -0700, Eric Blake wrote: On 03/03/2014 12:18 PM, Daniel P. Berrange wrote: Both of these options have a notable performance impact, however, and it is believed that worst case behaviour where the fields are

Re: [libvirt] [PATCH 6/7] Switch to filtering based on log source name instead of filename

2014-03-07 Thread Eric Blake
On 03/03/2014 12:18 PM, Daniel P. Berrange wrote: Currently the log filter strings are used in a string comparison against the source filename each time log message is emitted. If no log filters at all are set, there's obviously no string comparison to be done. If any single log filter is set

[libvirt] [PATCH 6/7] Switch to filtering based on log source name instead of filename

2014-03-03 Thread Daniel P. Berrange
Currently the log filter strings are used in a string comparison against the source filename each time log message is emitted. If no log filters at all are set, there's obviously no string comparison to be done. If any single log filter is set though, this imposes a compute burden on every logging