Re: [libvirt] [PATCH 6/7] qemu: assume -drive argument is always available

2015-11-06 Thread Daniel P. Berrange
On Thu, Nov 05, 2015 at 04:51:10PM -0500, John Ferlan wrote: > > > On 11/05/2015 12:33 PM, Daniel P. Berrange wrote: > > As of QEMU 0.9.1 the -drive argument can be used to configure > > all disks, so the QEMU driver can assume it is always available > > and drop support for -hda/-cdrom/etc. > >

Re: [libvirt] [PATCH 6/7] qemu: assume -drive argument is always available

2015-11-05 Thread John Ferlan
[...] Ran the series through the Coverity checks... > diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c > index 79d1692..7676237 100644 > --- a/src/qemu/qemu_capabilities.c > +++ b/src/qemu/qemu_capabilities.c > @@ -1104,29 +1104,27 @@ virQEMUCapsComputeCmdFlags(const

Re: [libvirt] [PATCH 6/7] qemu: assume -drive argument is always available

2015-11-05 Thread John Ferlan
On 11/05/2015 12:33 PM, Daniel P. Berrange wrote: > As of QEMU 0.9.1 the -drive argument can be used to configure > all disks, so the QEMU driver can assume it is always available > and drop support for -hda/-cdrom/etc. > > Many of the tests need updating because a great many were > running

Re: [libvirt] [PATCH 6/7] qemu: assume -drive argument is always available

2015-11-05 Thread John Ferlan
On 11/05/2015 12:33 PM, Daniel P. Berrange wrote: > As of QEMU 0.9.1 the -drive argument can be used to configure > all disks, so the QEMU driver can assume it is always available > and drop support for -hda/-cdrom/etc. > > Many of the tests need updating because a great many were > running