Re: [libvirt] [PATCH 6/8] virQEMUCapsSetFromNodes: Skip setting deprecated flags

2019-03-07 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 01:34:15PM +0100, Erik Skultety wrote: > On Thu, Mar 07, 2019 at 01:23:14PM +0100, Michal Privoznik wrote: > > On 3/7/19 1:07 PM, Daniel P. Berrangé wrote: > > > On Thu, Mar 07, 2019 at 12:52:46PM +0100, Erik Skultety wrote: > > > > > However, looking at the bigger picture i

Re: [libvirt] [PATCH 6/8] virQEMUCapsSetFromNodes: Skip setting deprecated flags

2019-03-07 Thread Michal Privoznik
On 3/7/19 1:27 PM, Daniel P. Berrangé wrote: On Thu, Mar 07, 2019 at 01:23:14PM +0100, Michal Privoznik wrote: On 3/7/19 1:07 PM, Daniel P. Berrangé wrote: On Thu, Mar 07, 2019 at 12:52:46PM +0100, Erik Skultety wrote: However, looking at the bigger picture is this a safe thing to do? I mean,

Re: [libvirt] [PATCH 6/8] virQEMUCapsSetFromNodes: Skip setting deprecated flags

2019-03-07 Thread Erik Skultety
On Thu, Mar 07, 2019 at 01:23:14PM +0100, Michal Privoznik wrote: > On 3/7/19 1:07 PM, Daniel P. Berrangé wrote: > > On Thu, Mar 07, 2019 at 12:52:46PM +0100, Erik Skultety wrote: > > > > However, looking at the bigger picture is this a safe thing to do? I > > > > mean, > > > > imagine the followi

Re: [libvirt] [PATCH 6/8] virQEMUCapsSetFromNodes: Skip setting deprecated flags

2019-03-07 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 01:23:14PM +0100, Michal Privoznik wrote: > On 3/7/19 1:07 PM, Daniel P. Berrangé wrote: > > On Thu, Mar 07, 2019 at 12:52:46PM +0100, Erik Skultety wrote: > > > > However, looking at the bigger picture is this a safe thing to do? I > > > > mean, > > > > imagine the followi

Re: [libvirt] [PATCH 6/8] virQEMUCapsSetFromNodes: Skip setting deprecated flags

2019-03-07 Thread Michal Privoznik
On 3/7/19 1:07 PM, Daniel P. Berrangé wrote: On Thu, Mar 07, 2019 at 12:52:46PM +0100, Erik Skultety wrote: However, looking at the bigger picture is this a safe thing to do? I mean, imagine the following scenario: 1) say there is capability X that affects certain part of cmd line. And assume t

Re: [libvirt] [PATCH 6/8] virQEMUCapsSetFromNodes: Skip setting deprecated flags

2019-03-07 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 12:52:46PM +0100, Erik Skultety wrote: > > However, looking at the bigger picture is this a safe thing to do? I mean, > > imagine the following scenario: > > > > 1) say there is capability X that affects certain part of cmd line. And > > assume that those two possibilities a

Re: [libvirt] [PATCH 6/8] virQEMUCapsSetFromNodes: Skip setting deprecated flags

2019-03-07 Thread Erik Skultety
> However, looking at the bigger picture is this a safe thing to do? I mean, > imagine the following scenario: > > 1) say there is capability X that affects certain part of cmd line. And > assume that those two possibilities are incompatible. If cmd line is > generated one way then migration to a q

Re: [libvirt] [PATCH 6/8] virQEMUCapsSetFromNodes: Skip setting deprecated flags

2019-03-07 Thread Michal Privoznik
On 2/21/19 4:42 PM, Ján Tomko wrote: Prepare for removal of deprecated flags from the capability string array and quietly drop flags present in the deprecated string array if they were not found in the main array. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 12 +--- 1

[libvirt] [PATCH 6/8] virQEMUCapsSetFromNodes: Skip setting deprecated flags

2019-02-22 Thread Ján Tomko
Prepare for removal of deprecated flags from the capability string array and quietly drop flags present in the deprecated string array if they were not found in the main array. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletio