Re: [libvirt] [PATCH 6/9] virsh: Rework parseRateStr

2015-08-11 Thread Michal Privoznik
On 11.08.2015 03:09, John Ferlan wrote: > > > On 08/03/2015 02:39 AM, Michal Privoznik wrote: >> The function is used to parse a tuple delimited by commas into >> virNetDevBandwidth structure. So far only three out of fore >> fields are supported: average, peak and burst. The single missing >> fi

Re: [libvirt] [PATCH 6/9] virsh: Rework parseRateStr

2015-08-10 Thread John Ferlan
On 08/03/2015 02:39 AM, Michal Privoznik wrote: > The function is used to parse a tuple delimited by commas into > virNetDevBandwidth structure. So far only three out of fore > fields are supported: average, peak and burst. The single missing > field is floor. Well, the parsing works, but I think

[libvirt] [PATCH 6/9] virsh: Rework parseRateStr

2015-08-02 Thread Michal Privoznik
The function is used to parse a tuple delimited by commas into virNetDevBandwidth structure. So far only three out of fore fields are supported: average, peak and burst. The single missing field is floor. Well, the parsing works, but I think we can do better. Especially when we will need to parse f