Re: [libvirt] [PATCH 7/7] Set a security context on /dev and /dev/pts mounts

2012-01-24 Thread Eric Blake
On 01/11/2012 09:33 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com To allow the container to access /dev and /dev/pts when under sVirt, set an explicit mount option. Also set a max size on the /dev mount to prevent DOS on memory usage * src/lxc/lxc_container.c:

Re: [libvirt] [PATCH 7/7] Set a security context on /dev and /dev/pts mounts

2012-01-24 Thread Eric Blake
On 01/24/2012 01:21 PM, Eric Blake wrote: +if (virAsprintf(opts, mode=755,size=65536%%%s%s%s, +con ? ,context=\ : , +con ? (const char *)con : , +con ? \ : ) 0) { I would have split this: if

[libvirt] [PATCH 7/7] Set a security context on /dev and /dev/pts mounts

2012-01-11 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com To allow the container to access /dev and /dev/pts when under sVirt, set an explicit mount option. Also set a max size on the /dev mount to prevent DOS on memory usage * src/lxc/lxc_container.c: Set /dev mount context * src/lxc/lxc_controller.c: Set