Re: [libvirt] [PATCH 7/7] qemudDomainAttachSCSIDisk: avoid FP NULL-ptr-deref from clang

On Wed, Apr 14, 2010 at 06:02:36PM +0200, Jim Meyering wrote: > From: Jim Meyering > > * src/util/conf.c (virConfParseValue): Add an sa_assert. > --- > src/util/conf.c |9 - > 1 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/src/util/conf.c b/src/util/conf.c > index

Re: [libvirt] [PATCH 7/7] qemudDomainAttachSCSIDisk: avoid FP NULL-ptr-deref from clang

Eric Blake wrote: > On 04/14/2010 10:02 AM, Jim Meyering wrote: >> From: Jim Meyering >> >> * src/util/conf.c (virConfParseValue): Add an sa_assert. >> --- >> src/util/conf.c |9 - >> 1 files changed, 8 insertions(+), 1 deletions(-) > > A little more context makes this obvious: Good

Re: [libvirt] [PATCH 7/7] qemudDomainAttachSCSIDisk: avoid FP NULL-ptr-deref from clang

On 04/14/2010 10:02 AM, Jim Meyering wrote: > From: Jim Meyering > > * src/util/conf.c (virConfParseValue): Add an sa_assert. > --- > src/util/conf.c |9 - > 1 files changed, 8 insertions(+), 1 deletions(-) > A little more context makes this obvious: if ((ctxt->cur < ctxt-

[libvirt] [PATCH 7/7] qemudDomainAttachSCSIDisk: avoid FP NULL-ptr-deref from clang

From: Jim Meyering * src/util/conf.c (virConfParseValue): Add an sa_assert. --- src/util/conf.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/src/util/conf.c b/src/util/conf.c index ae0459e..38eb163 100644 --- a/src/util/conf.c +++ b/src/util/conf.c @@ -1,7 +1,