Re: [libvirt] [PATCH 7/7] remote generator: Annotate hyper with the actual C type

2011-05-31 Thread Eric Blake
On 05/27/2011 04:12 AM, Daniel P. Berrange wrote: But anything is better than nothing, so I won't give any further complaints if we go with your idea of only annotating the exceptions to the 'long long' default, rather than all uses of hyper. My rationale for defaulting to 'long long' is

Re: [libvirt] [PATCH 7/7] remote generator: Annotate hyper with the actual C type

2011-05-27 Thread Daniel P. Berrange
On Wed, May 25, 2011 at 10:33:06AM -0600, Eric Blake wrote: On 05/25/2011 10:23 AM, Daniel P. Berrange wrote: On Mon, May 23, 2011 at 07:36:10PM +0200, Matthias Bolte wrote: Remove some special case code that took care of mapping hyper to the correct C types. Use macros for hyper to

Re: [libvirt] [PATCH 7/7] remote generator: Annotate hyper with the actual C type

2011-05-25 Thread Daniel P. Berrange
On Mon, May 23, 2011 at 07:36:10PM +0200, Matthias Bolte wrote: Remove some special case code that took care of mapping hyper to the correct C types. Use macros for hyper to long assignments that perform overflow checks when long is smaller than hyper. Also use such macros for the safe

Re: [libvirt] [PATCH 7/7] remote generator: Annotate hyper with the actual C type

2011-05-25 Thread Eric Blake
On 05/25/2011 10:23 AM, Daniel P. Berrange wrote: On Mon, May 23, 2011 at 07:36:10PM +0200, Matthias Bolte wrote: Remove some special case code that took care of mapping hyper to the correct C types. Use macros for hyper to long assignments that perform overflow checks when long is smaller

Re: [libvirt] [PATCH 7/7] remote generator: Annotate hyper with the actual C type

2011-05-25 Thread Matthias Bolte
2011/5/25 Eric Blake ebl...@redhat.com: On 05/25/2011 10:23 AM, Daniel P. Berrange wrote: On Mon, May 23, 2011 at 07:36:10PM +0200, Matthias Bolte wrote: Remove some special case code that took care of mapping hyper to the correct C types. Use macros for hyper to long assignments that

[libvirt] [PATCH 7/7] remote generator: Annotate hyper with the actual C type

2011-05-23 Thread Matthias Bolte
Remove some special case code that took care of mapping hyper to the correct C types. Use macros for hyper to long assignments that perform overflow checks when long is smaller than hyper. Also use such macros for the safe hyper to longlong assignemts as this allows to keep the generator a bit