Re: [libvirt] [PATCH 7/8] secret: Properly handle @def after virSecretObjAdd in driver

2017-07-14 Thread John Ferlan
On 07/14/2017 08:26 AM, Michal Privoznik wrote: > On 07/14/2017 02:01 PM, John Ferlan wrote: >> >> >> On 07/14/2017 04:26 AM, Michal Privoznik wrote: >>> On 07/13/2017 06:54 PM, John Ferlan wrote: On 07/11/2017 11:52 AM, Michal Privoznik wrote: > On 06/03/2017 03:27 PM, John

Re: [libvirt] [PATCH 7/8] secret: Properly handle @def after virSecretObjAdd in driver

2017-07-14 Thread Michal Privoznik
On 07/14/2017 02:01 PM, John Ferlan wrote: > > > On 07/14/2017 04:26 AM, Michal Privoznik wrote: >> On 07/13/2017 06:54 PM, John Ferlan wrote: >>> >>> >>> On 07/11/2017 11:52 AM, Michal Privoznik wrote: On 06/03/2017 03:27 PM, John Ferlan wrote: > Since the virSecretObjListAdd

Re: [libvirt] [PATCH 7/8] secret: Properly handle @def after virSecretObjAdd in driver

2017-07-14 Thread John Ferlan
On 07/14/2017 04:26 AM, Michal Privoznik wrote: > On 07/13/2017 06:54 PM, John Ferlan wrote: >> >> >> On 07/11/2017 11:52 AM, Michal Privoznik wrote: >>> On 06/03/2017 03:27 PM, John Ferlan wrote: Since the virSecretObjListAdd technically consumes @def on success, the secretDefineXML

Re: [libvirt] [PATCH 7/8] secret: Properly handle @def after virSecretObjAdd in driver

2017-07-14 Thread Michal Privoznik
On 07/13/2017 06:54 PM, John Ferlan wrote: > > > On 07/11/2017 11:52 AM, Michal Privoznik wrote: >> On 06/03/2017 03:27 PM, John Ferlan wrote: >>> Since the virSecretObjListAdd technically consumes @def on success, >>> the secretDefineXML should fetch the @def from the object afterwards >>> and

Re: [libvirt] [PATCH 7/8] secret: Properly handle @def after virSecretObjAdd in driver

2017-07-13 Thread John Ferlan
On 07/11/2017 11:52 AM, Michal Privoznik wrote: > On 06/03/2017 03:27 PM, John Ferlan wrote: >> Since the virSecretObjListAdd technically consumes @def on success, >> the secretDefineXML should fetch the @def from the object afterwards >> and manage as an @objdef and set @def = NULL immediately.

Re: [libvirt] [PATCH 7/8] secret: Properly handle @def after virSecretObjAdd in driver

2017-07-11 Thread Michal Privoznik
On 06/03/2017 03:27 PM, John Ferlan wrote: > Since the virSecretObjListAdd technically consumes @def on success, > the secretDefineXML should fetch the @def from the object afterwards > and manage as an @objdef and set @def = NULL immediately. Really? virSecretObjListAdd sets ->def pointer in the

[libvirt] [PATCH 7/8] secret: Properly handle @def after virSecretObjAdd in driver

2017-06-03 Thread John Ferlan
Since the virSecretObjListAdd technically consumes @def on success, the secretDefineXML should fetch the @def from the object afterwards and manage as an @objdef and set @def = NULL immediately. Signed-off-by: John Ferlan --- src/secret/secret_driver.c | 18