Re: [libvirt] [PATCH 7/8 v8] qemu: Set unpriv_sgio when attaching disk

2012-12-18 Thread Osier Yang
On 2012年12月19日 02:03, Eric Blake wrote: On 12/16/2012 12:32 PM, Osier Yang wrote: Again, does this do the right thing if some other domain already had cdbfilter='no' (aka kernel allows SG_IO) but this domain omitted the cdbfilter attribute (which defaults to cdbfilter='yes' but does not satisfy

Re: [libvirt] [PATCH 7/8 v8] qemu: Set unpriv_sgio when attaching disk

2012-12-18 Thread Eric Blake
On 12/16/2012 12:32 PM, Osier Yang wrote: >> Again, does this do the right thing if some other domain already had >> cdbfilter='no' (aka kernel allows SG_IO) but this domain omitted the >> cdbfilter attribute (which defaults to cdbfilter='yes' but does not >> satisfy the if(disk->cdbfilter) conditi

Re: [libvirt] [PATCH 7/8 v8] qemu: Set unpriv_sgio when attaching disk

2012-12-16 Thread Osier Yang
On 2012年12月15日 06:05, Eric Blake wrote: On 12/14/2012 08:45 AM, Osier Yang wrote: Just like for domain starting, this sets the disk's unpriv_sgio if cdbfilter is specified when attaching disk. --- src/qemu/qemu_driver.c | 23 +-- 1 files changed, 17 insertions(+), 6 dele

Re: [libvirt] [PATCH 7/8 v8] qemu: Set unpriv_sgio when attaching disk

2012-12-14 Thread Eric Blake
On 12/14/2012 08:45 AM, Osier Yang wrote: > Just like for domain starting, this sets the disk's unpriv_sgio > if cdbfilter is specified when attaching disk. > --- > src/qemu/qemu_driver.c | 23 +-- > 1 files changed, 17 insertions(+), 6 deletions(-) > + > +/* Set sys

[libvirt] [PATCH 7/8 v8] qemu: Set unpriv_sgio when attaching disk

2012-12-14 Thread Osier Yang
Just like for domain starting, this sets the disk's unpriv_sgio if cdbfilter is specified when attaching disk. --- src/qemu/qemu_driver.c | 23 +-- 1 files changed, 17 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a2700de..b