Re: [libvirt] [PATCH 7/9] qemu: Grab modify job for changing domain XML

2019-06-04 Thread Nikolay Shirokovskiy
On 04.06.2019 17:23, Michal Privoznik wrote: > On 6/4/19 11:07 AM, Nikolay Shirokovskiy wrote: >> >> >> On 30.05.2019 12:34, Michal Privoznik wrote: >>> Changing domain definition must be guarded with acquiring modify >>> job. The problem is if there is a thread executing say >>>

Re: [libvirt] [PATCH 7/9] qemu: Grab modify job for changing domain XML

2019-06-04 Thread Michal Privoznik
On 6/4/19 11:07 AM, Nikolay Shirokovskiy wrote: On 30.05.2019 12:34, Michal Privoznik wrote: Changing domain definition must be guarded with acquiring modify job. The problem is if there is a thread executing say qemuDomainSetMemoryStatsPeriod() which is an API that acquires modify job and

Re: [libvirt] [PATCH 7/9] qemu: Grab modify job for changing domain XML

2019-06-04 Thread Nikolay Shirokovskiy
On 30.05.2019 12:34, Michal Privoznik wrote: > Changing domain definition must be guarded with acquiring modify > job. The problem is if there is a thread executing say > qemuDomainSetMemoryStatsPeriod() which is an API that acquires > modify job and then possibly unlock the domain object and

[libvirt] [PATCH 7/9] qemu: Grab modify job for changing domain XML

2019-05-30 Thread Michal Privoznik
Changing domain definition must be guarded with acquiring modify job. The problem is if there is a thread executing say qemuDomainSetMemoryStatsPeriod() which is an API that acquires modify job and then possibly unlock the domain object and locks it again. However, becasue virDomainObjAssignDef()