Re: [libvirt] [PATCH 8/8] qemu: enable blockdev support

2019-11-22 Thread Daniel P . Berrangé
On Thu, Nov 21, 2019 at 06:32:11PM +, Daniel P. Berrangé wrote: > On Mon, Nov 18, 2019 at 06:02:08PM +0100, Peter Krempa wrote: > > Now that all pieces are in place (hopefully) let's enable -blockdev. > > > > We base the capability on presence of the fix for 'auto-read-only' on > > files so

Re: [libvirt] [PATCH 8/8] qemu: enable blockdev support

2019-11-22 Thread Peter Krempa
On Thu, Nov 21, 2019 at 18:32:11 +, Daniel Berrange wrote: > On Mon, Nov 18, 2019 at 06:02:08PM +0100, Peter Krempa wrote: > > Now that all pieces are in place (hopefully) let's enable -blockdev. > > > > We base the capability on presence of the fix for 'auto-read-only' on > > files so that

Re: [libvirt] [PATCH 8/8] qemu: enable blockdev support

2019-11-21 Thread Daniel P . Berrangé
On Mon, Nov 18, 2019 at 06:02:08PM +0100, Peter Krempa wrote: > Now that all pieces are in place (hopefully) let's enable -blockdev. > > We base the capability on presence of the fix for 'auto-read-only' on > files so that blockdev works properly, mandate that qemu supports > explicit SCSI id

[libvirt] [PATCH 8/8] qemu: enable blockdev support

2019-11-18 Thread Peter Krempa
Now that all pieces are in place (hopefully) let's enable -blockdev. We base the capability on presence of the fix for 'auto-read-only' on files so that blockdev works properly, mandate that qemu supports explicit SCSI id strings to avoid ABI regression and that the fix for 'savevm' is present so