Re: [libvirt] [PATCH 8/8] secret: Handle object list removal and deletion properly

2017-07-14 Thread John Ferlan
On 07/14/2017 04:15 AM, Michal Privoznik wrote: > On 07/13/2017 07:19 PM, John Ferlan wrote: >> >> >> On 07/11/2017 11:52 AM, Michal Privoznik wrote: >>> On 06/03/2017 03:27 PM, John Ferlan wrote: Rather than rely on virSecretObjEndAPI to make the final virObjectUnref after the call

Re: [libvirt] [PATCH 8/8] secret: Handle object list removal and deletion properly

2017-07-14 Thread Michal Privoznik
On 07/13/2017 07:19 PM, John Ferlan wrote: > > > On 07/11/2017 11:52 AM, Michal Privoznik wrote: >> On 06/03/2017 03:27 PM, John Ferlan wrote: >>> Rather than rely on virSecretObjEndAPI to make the final virObjectUnref >>> after the call virSecretObjListRemove, be more explicit by calling >>>

Re: [libvirt] [PATCH 8/8] secret: Handle object list removal and deletion properly

2017-07-13 Thread John Ferlan
On 07/11/2017 11:52 AM, Michal Privoznik wrote: > On 06/03/2017 03:27 PM, John Ferlan wrote: >> Rather than rely on virSecretObjEndAPI to make the final virObjectUnref >> after the call virSecretObjListRemove, be more explicit by calling >> virObjectUnref and setting @obj to NULL for

Re: [libvirt] [PATCH 8/8] secret: Handle object list removal and deletion properly

2017-07-11 Thread Michal Privoznik
On 06/03/2017 03:27 PM, John Ferlan wrote: > Rather than rely on virSecretObjEndAPI to make the final virObjectUnref > after the call virSecretObjListRemove, be more explicit by calling > virObjectUnref and setting @obj to NULL for secretUndefine and in > the error path of secretDefineXML. > >

[libvirt] [PATCH 8/8] secret: Handle object list removal and deletion properly

2017-06-03 Thread John Ferlan
Rather than rely on virSecretObjEndAPI to make the final virObjectUnref after the call virSecretObjListRemove, be more explicit by calling virObjectUnref and setting @obj to NULL for secretUndefine and in the error path of secretDefineXML. This also fixes a leak during virSecretLoad if the