Re: [libvirt] [PATCH 8/9] Simplified version of volume zeroing based on feedback from the list.

2010-03-04 Thread Jim Meyering
David Allan wrote: > diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c ... Hi Dave, > +static int > +storageVolumeZeroSparseFile(virStorageVolDefPtr vol, > +struct stat *st, > +int fd) Since the only use of "st" is fo

Re: [libvirt] [PATCH 8/9] Simplified version of volume zeroing based on feedback from the list.

2010-03-04 Thread Daniel P. Berrange
On Tue, Mar 02, 2010 at 05:13:33PM -0500, David Allan wrote: > @@ -1518,6 +1521,220 @@ cleanup: > return ret; > + > +static int > +storageZeroExtent(virStorageVolDefPtr vol, > + struct stat *st, > + int fd, > + size_t extent_start, > +

Re: [libvirt] [PATCH 8/9] Simplified version of volume zeroing based on feedback from the list.

2010-03-03 Thread Dave Allan
On 03/02/2010 06:44 PM, Eric Blake wrote: According to David Allan on 3/2/2010 3:13 PM: +ret = ftruncate(fd, st->st_size); +if (ret == -1) { +virReportSystemError(ret, + _("Failed to truncate volume with " + "path '%s' to

Re: [libvirt] [PATCH 8/9] Simplified version of volume zeroing based on feedback from the list.

2010-03-02 Thread Eric Blake
According to David Allan on 3/2/2010 3:13 PM: > +ret = ftruncate(fd, st->st_size); > +if (ret == -1) { > +virReportSystemError(ret, > + _("Failed to truncate volume with " > + "path '%s' to %llu bytes: '%s'\n"), > +

[libvirt] [PATCH 8/9] Simplified version of volume zeroing based on feedback from the list.

2010-03-02 Thread David Allan
--- src/storage/storage_driver.c | 218 ++ 1 files changed, 218 insertions(+), 0 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 6b1045a..9e63689 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storag