Re: [libvirt] [PATCH 9/9] Fix the signature of virDomainMigrateFinish3 for error reporting

2011-05-25 Thread Matthias Bolte
2011/5/24 Daniel P. Berrange berra...@redhat.com: The current virDomainMigrateFinish3 method signature attempts to distinguish two types of errors, by allowing return with ret== 0, but ddomain == NULL, to indicate a failure to start the guest. This is flawed, because when ret == 0, there is no

[libvirt] [PATCH 9/9] Fix the signature of virDomainMigrateFinish3 for error reporting

2011-05-24 Thread Daniel P. Berrange
The current virDomainMigrateFinish3 method signature attempts to distinguish two types of errors, by allowing return with ret== 0, but ddomain == NULL, to indicate a failure to start the guest. This is flawed, because when ret == 0, there is no way for the virErrorPtr details to be sent back to