Re: [libvirt] [PATCH LIBVIRT] libxl: don't end job for ephemeal domain on start failure

2015-09-11 Thread Michal Privoznik
On 10.09.2015 17:45, Ian Campbell wrote: > commit 4b53d0d4ac9c "libxl: don't remove persistent domain on start > failure" cleans up the vm object and sets it to NULL if the vm is not > persistent, however at end job vm (now NULL) is dereferenced via the call to > libxlDomainObjEndJob. Avoid this

Re: [libvirt] [PATCH LIBVIRT] libxl: don't end job for ephemeal domain on start failure

2015-09-11 Thread Jim Fehlig
On 09/11/2015 03:14 AM, Michal Privoznik wrote: On 10.09.2015 17:45, Ian Campbell wrote: commit 4b53d0d4ac9c "libxl: don't remove persistent domain on start failure" cleans up the vm object and sets it to NULL if the vm is not persistent, however at end job vm (now NULL) is dereferenced via the

[libvirt] [PATCH LIBVIRT] libxl: don't end job for ephemeal domain on start failure

2015-09-10 Thread Ian Campbell
commit 4b53d0d4ac9c "libxl: don't remove persistent domain on start failure" cleans up the vm object and sets it to NULL if the vm is not persistent, however at end job vm (now NULL) is dereferenced via the call to libxlDomainObjEndJob. Avoid this by skipping "endjob" and going straight to