Re: [libvirt] [PATCH RESEND] Added support for portable-rpcgen from portablexdr library

2015-07-07 Thread Pavel Fedin
Hello! > Could you split that hunk into another patch and also fix it in > lxc_monitor_protocol-structs so that make syntax-check doesn't bother > us? No problem, i will do it. If i have further questions, i'll ask them tomorrow because i'm in 40 minutes apart from leaving the office today. K

Re: [libvirt] [PATCH RESEND] Added support for portable-rpcgen from portablexdr library

2015-07-07 Thread Martin Kletzander
On Tue, Jul 07, 2015 at 03:04:51PM +0300, Pavel Fedin wrote: Hello! I don't think we should use enums at all in the protocol specification. It should be unsigned int and the change should be made separately. Is this hunk here because portable-rpcgen has problems with enum being declared there

Re: [libvirt] [PATCH RESEND] Added support for portable-rpcgen from portablexdr library

2015-07-07 Thread Pavel Fedin
Hello! > I don't think we should use enums at all in the protocol > specification. It should be unsigned int and the change should be > made separately. Is this hunk here because portable-rpcgen has > problems with enum being declared there? Yes, its parser fails. I have checked throughout t

Re: [libvirt] [PATCH RESEND] Added support for portable-rpcgen from portablexdr library

2015-07-07 Thread Martin Kletzander
On Mon, Jul 06, 2015 at 10:40:28AM +0300, Pavel Fedin wrote: This patch allows to build libvirt natively under MinGW/MSYS using portablexdr library. An updated version of portablexdr with fixed bugs is available as part of MSYS2 project. Signed-off-by: Pavel Fedin --- configure.ac

[libvirt] [PATCH RESEND] Added support for portable-rpcgen from portablexdr library

2015-07-06 Thread Pavel Fedin
This patch allows to build libvirt natively under MinGW/MSYS using portablexdr library. An updated version of portablexdr with fixed bugs is available as part of MSYS2 project. Signed-off-by: Pavel Fedin --- configure.ac | 2 +- src/lxc/lxc_monitor_protocol.x | 2 +- src/rpc/