Re: [libvirt] [PATCH RESEND] qdev: Make "hotplugged" property read-only

2017-02-22 Thread Eduardo Habkost
On Wed, Feb 22, 2017 at 04:43:37PM -0600, Eric Blake wrote: > On 02/22/2017 01:26 PM, Eduardo Habkost wrote: > > The "hotplugged" property is user visible, but it was never meant > > to be set by the user. There are probably multiple ways to break > > or crash device code by overriding the

Re: [libvirt] [PATCH RESEND] qdev: Make "hotplugged" property read-only

2017-02-22 Thread Eric Blake
On 02/22/2017 01:26 PM, Eduardo Habkost wrote: > The "hotplugged" property is user visible, but it was never meant > to be set by the user. There are probably multiple ways to break > or crash device code by overriding the property. For example, we > recently fixed a crash in rtc_set_memory()

[libvirt] [PATCH RESEND] qdev: Make "hotplugged" property read-only

2017-02-22 Thread Eduardo Habkost
The "hotplugged" property is user visible, but it was never meant to be set by the user. There are probably multiple ways to break or crash device code by overriding the property. For example, we recently fixed a crash in rtc_set_memory() related to the property (commit