Re: [libvirt] [PATCH RFC] qemu: make time adjustment persistent if RTC changes in guest

2014-09-05 Thread Wang Rui
On 2014/9/5 1:40, Laine Stump wrote: I do point out the existence of exactly the problem that you are fixing. However, there is a problem with the way you're fixing it if the clock for the domain is set like this: clock offset ='variable' basis='localtime'/ The problem is that when the

Re: [libvirt] [PATCH RFC] qemu: make time adjustment persistent if RTC changes in guest

2014-09-04 Thread Laine Stump
On 08/20/2014 09:00 AM, Wang Rui wrote: Domain's clock xml is as below. clock offset='variable' basis='utc' adjustment='10'/ If the guest modifies its RTC, libvirt will hanlde the time offset and save the active status in qemuProcessHandleRTCChange(). However, libvirt won't save the

[libvirt] [PATCH RFC] qemu: make time adjustment persistent if RTC changes in guest

2014-08-20 Thread Wang Rui
Domain's clock xml is as below. clock offset='variable' basis='utc' adjustment='10'/ If the guest modifies its RTC, libvirt will hanlde the time offset and save the active status in qemuProcessHandleRTCChange(). However, libvirt won't save the persistent config. So next time when vm is