Re: [libvirt] [PATCH RFC 09/22] qemu_capabilities: Detect caps probe failure by checking monitor ptr

2018-11-27 Thread Jiri Denemark
On Sun, Nov 11, 2018 at 13:59:17 -0600, Chris Venteicher wrote: > Failure to connect to QEMU to probe capabilities is not considered a error > case > and does not result in a negative return value. That's not really true anymore. It used to be true when there was a fallback to parsing qemu -help

Re: [libvirt] [PATCH RFC 09/22] qemu_capabilities: Detect caps probe failure by checking monitor ptr

2018-11-14 Thread Michal Privoznik
On 11/11/2018 08:59 PM, Chris Venteicher wrote: > Failure to connect to QEMU to probe capabilities is not considered a error > case > and does not result in a negative return value. > > Check for a NULL monitor connection pointer before trying to send capabilities > commands to QEMU rather than

[libvirt] [PATCH RFC 09/22] qemu_capabilities: Detect caps probe failure by checking monitor ptr

2018-11-11 Thread Chris Venteicher
Failure to connect to QEMU to probe capabilities is not considered a error case and does not result in a negative return value. Check for a NULL monitor connection pointer before trying to send capabilities commands to QEMU rather than depending on a special positive return value. This