Re: [libvirt] [PATCH RFC 18/40] conf: snapshot: Remove 'update_current' parameter from virDomainSnapshotRedefinePrep

2019-11-07 Thread Eric Blake
On 10/18/19 11:11 AM, Peter Krempa wrote: The variable is unused so we can drop it. Signed-off-by: Peter Krempa --- Merging 17 and 18 might make it easier to review (proof who the callers were, to audit that all callers will manage to update the current snapshot without help from the parame

Re: [libvirt] [PATCH RFC 18/40] conf: snapshot: Remove 'update_current' parameter from virDomainSnapshotRedefinePrep

2019-10-23 Thread Ján Tomko
On Fri, Oct 18, 2019 at 06:11:03PM +0200, Peter Krempa wrote: The variable is unused so we can drop it. Signed-off-by: Peter Krempa --- src/conf/snapshot_conf.c | 1 - src/conf/snapshot_conf.h | 1 - src/qemu/qemu_driver.c | 2 +- src/test/test_driver.c | 2 +- 4 files changed, 2 insertions(+),

[libvirt] [PATCH RFC 18/40] conf: snapshot: Remove 'update_current' parameter from virDomainSnapshotRedefinePrep

2019-10-18 Thread Peter Krempa
The variable is unused so we can drop it. Signed-off-by: Peter Krempa --- src/conf/snapshot_conf.c | 1 - src/conf/snapshot_conf.h | 1 - src/qemu/qemu_driver.c | 2 +- src/test/test_driver.c | 2 +- 4 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/conf/snapshot_conf.c b/sr