Re: [libvirt] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

2016-06-03 Thread Peter Krempa
On Thu, Jun 02, 2016 at 18:31:04 +0200, Igor Mammedov wrote: > On Thu, 2 Jun 2016 17:05:06 +0200 > Peter Krempa wrote: > > On Thu, Jun 02, 2016 at 11:53:22 -0300, Eduardo Habkost wrote: > > > On Thu, Jun 02, 2016 at 02:22:22PM +0200, Igor Mammedov wrote: [...] > > I couldn't

Re: [libvirt] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

2016-06-02 Thread Igor Mammedov
On Thu, 2 Jun 2016 17:05:06 +0200 Peter Krempa wrote: > On Thu, Jun 02, 2016 at 11:53:22 -0300, Eduardo Habkost wrote: > > (CCing libvirt folks) > > > > BTW: > > > > On Thu, Jun 02, 2016 at 02:22:22PM +0200, Igor Mammedov wrote: > > [...] > > > > /* Special cases:

Re: [libvirt] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

2016-06-02 Thread Peter Krempa
On Thu, Jun 02, 2016 at 11:53:22 -0300, Eduardo Habkost wrote: > (CCing libvirt folks) > > BTW: > > On Thu, Jun 02, 2016 at 02:22:22PM +0200, Igor Mammedov wrote: > [...] > > > /* Special cases: */ > > > if (!strcmp(name, "xlevel")) { > > > numvalue = strtoul(val, ,

Re: [libvirt] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

2016-06-02 Thread Eduardo Habkost
(CCing libvirt folks) BTW: On Thu, Jun 02, 2016 at 02:22:22PM +0200, Igor Mammedov wrote: [...] > > /* Special cases: */ > > if (!strcmp(name, "xlevel")) { > > numvalue = strtoul(val, , 0); > > if (!*val || *err) { > > error_setg(errp, "bad