Re: [libvirt] [PATCH V2] libxl: don't overwrite error from virNetSocketNewConnectTCP()

2015-09-04 Thread Michal Privoznik
On 03.09.2015 22:55, John Ferlan wrote: > > > On 09/03/2015 01:40 PM, Jim Fehlig wrote: >> Remove redundant error reporting in libxlDomainMigrationPerform(). >> virNetSocketNewConnectTCP() is perfectly capable of reporting >> sensible errors. >> >> Signed-off-by: Jim Fehlig >>

[libvirt] [PATCH V2] libxl: don't overwrite error from virNetSocketNewConnectTCP()

2015-09-03 Thread Jim Fehlig
Remove redundant error reporting in libxlDomainMigrationPerform(). virNetSocketNewConnectTCP() is perfectly capable of reporting sensible errors. Signed-off-by: Jim Fehlig --- V2: Actually try to compile the code and find saved_errno is no longer used - remove it.

Re: [libvirt] [PATCH V2] libxl: don't overwrite error from virNetSocketNewConnectTCP()

2015-09-03 Thread John Ferlan
On 09/03/2015 01:40 PM, Jim Fehlig wrote: > Remove redundant error reporting in libxlDomainMigrationPerform(). > virNetSocketNewConnectTCP() is perfectly capable of reporting > sensible errors. > > Signed-off-by: Jim Fehlig > --- > > V2: > Actually try to compile the code

Re: [libvirt] [PATCH V2] libxl: don't overwrite error from virNetSocketNewConnectTCP()

2015-09-03 Thread Jim Fehlig
On 09/03/2015 02:55 PM, John Ferlan wrote: On 09/03/2015 01:40 PM, Jim Fehlig wrote: Remove redundant error reporting in libxlDomainMigrationPerform(). virNetSocketNewConnectTCP() is perfectly capable of reporting sensible errors. Signed-off-by: Jim Fehlig --- V2: