Re: [libvirt] [PATCH V2] tests: xmconfigtest: add tests for cmdline formating

2018-06-04 Thread Jim Fehlig
On 06/04/2018 12:29 PM, John Ferlan wrote: On 05/23/2018 05:31 PM, Jim Fehlig wrote: Commit 656151bf fixed formatting of the element. Perhaps it would have been noticed and fixed earlier if we had a test. With this change, all possible cases of formating from xmconfig are formatting

Re: [libvirt] [PATCH V2] tests: xmconfigtest: add tests for cmdline formating

2018-06-04 Thread John Ferlan
On 05/23/2018 05:31 PM, Jim Fehlig wrote: > Commit 656151bf fixed formatting of the element. Perhaps it > would have been noticed and fixed earlier if we had a test. With this > change, all possible cases of formating from xmconfig are formatting > covered > > 1. no 'extra=' or 'root=' in

[libvirt] [PATCH V2] tests: xmconfigtest: add tests for cmdline formating

2018-05-23 Thread Jim Fehlig
Commit 656151bf fixed formatting of the element. Perhaps it would have been noticed and fixed earlier if we had a test. With this change, all possible cases of formating from xmconfig are covered 1. no 'extra=' or 'root=' in xm.cfg 2. 'extra=' but no 'root=' in xm.cfg 3. 'root=' but no 'extra='