Re: [libvirt] [PATCH V2 1/3] libxl: fix ref counting of libxlMigrationDstArgs

2015-08-28 Thread Jim Fehlig
Michal Privoznik wrote: On 27.08.2015 23:38, Jim Fehlig wrote: How does it look with the following squashed in? diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index 8db3aea..9609e06 100644 --- a/src/libxl/libxl_migration.c +++ b/src/libxl/libxl_migration.c @@

Re: [libvirt] [PATCH V2 1/3] libxl: fix ref counting of libxlMigrationDstArgs

2015-08-27 Thread Jim Fehlig
Michal Privoznik wrote: On 07.08.2015 19:53, Jim Fehlig wrote: This patch fixes some flawed logic around ref counting the libxlMigrationDstArgs object. First, when adding sockets to the event loop with virNetSocketAddIOCallback(), the generic virObjectFreeCallback() was registered as a

Re: [libvirt] [PATCH V2 1/3] libxl: fix ref counting of libxlMigrationDstArgs

2015-08-27 Thread Michal Privoznik
On 27.08.2015 23:38, Jim Fehlig wrote: Michal Privoznik wrote: On 07.08.2015 19:53, Jim Fehlig wrote: This patch fixes some flawed logic around ref counting the libxlMigrationDstArgs object. First, when adding sockets to the event loop with virNetSocketAddIOCallback(), the generic

Re: [libvirt] [PATCH V2 1/3] libxl: fix ref counting of libxlMigrationDstArgs

2015-08-19 Thread Michal Privoznik
On 07.08.2015 19:53, Jim Fehlig wrote: This patch fixes some flawed logic around ref counting the libxlMigrationDstArgs object. First, when adding sockets to the event loop with virNetSocketAddIOCallback(), the generic virObjectFreeCallback() was registered as a free function, with

[libvirt] [PATCH V2 1/3] libxl: fix ref counting of libxlMigrationDstArgs

2015-08-07 Thread Jim Fehlig
This patch fixes some flawed logic around ref counting the libxlMigrationDstArgs object. First, when adding sockets to the event loop with virNetSocketAddIOCallback(), the generic virObjectFreeCallback() was registered as a free function, with libxlMigrationDstArgs as its parameter. A reference