Re: [libvirt] [PATCH V2 2/4] libxl: support hotplug USB host device

2016-05-23 Thread Chun Yan Liu
>>> On 5/24/2016 at 03:23 AM, in message <57435894.9080...@suse.com>, Jim Fehlig wrote: > On 05/23/2016 12:51 AM, Chun Yan Liu wrote: > > > > Yes, I think it's OK. And another place needs to be updated, since now it's > > not only pci device, but also could be usb device,

Re: [libvirt] [PATCH V2 2/4] libxl: support hotplug USB host device

2016-05-23 Thread Jim Fehlig
On 05/23/2016 12:51 AM, Chun Yan Liu wrote: > > Yes, I think it's OK. And another place needs to be updated, since now it's > not only pci device, but also could be usb device, so the error message > should be updated. > if (virDomainHostdevFind(vmdef, hostdev, ) >= 0) { > -

Re: [libvirt] [PATCH V2 2/4] libxl: support hotplug USB host device

2016-05-23 Thread Chun Yan Liu
>>> On 5/21/2016 at 05:25 AM, in message <573f80e3.4070...@suse.com>, Jim Fehlig wrote: > On 05/20/2016 02:25 PM, Jim Fehlig wrote: > > On 05/20/2016 04:32 AM, Joao Martins wrote: > >> On 05/19/2016 09:14 AM, Chunyan Liu wrote: > >>> Support hot attach/detach a USB host

Re: [libvirt] [PATCH V2 2/4] libxl: support hotplug USB host device

2016-05-22 Thread Chun Yan Liu
>>> On 5/20/2016 at 06:32 PM, in message <573ee7c3.7000...@oracle.com>, Joao Martins wrote: > On 05/19/2016 09:14 AM, Chunyan Liu wrote: > > Support hot attach/detach a USB host device to guest. > > Curretnly libxl only supports xen PV guest, and only > > supports

Re: [libvirt] [PATCH V2 2/4] libxl: support hotplug USB host device

2016-05-20 Thread Jim Fehlig
On 05/20/2016 02:25 PM, Jim Fehlig wrote: > On 05/20/2016 04:32 AM, Joao Martins wrote: >> On 05/19/2016 09:14 AM, Chunyan Liu wrote: >>> Support hot attach/detach a USB host device to guest. >>> Curretnly libxl only supports xen PV guest, and only > s/Curretnly/Currently/ > >>> supports

Re: [libvirt] [PATCH V2 2/4] libxl: support hotplug USB host device

2016-05-20 Thread Jim Fehlig
On 05/20/2016 04:32 AM, Joao Martins wrote: > On 05/19/2016 09:14 AM, Chunyan Liu wrote: >> Support hot attach/detach a USB host device to guest. >> Curretnly libxl only supports xen PV guest, and only s/Curretnly/Currently/ >> supports specifying USB host device by 'bus number' >> and 'device

Re: [libvirt] [PATCH V2 2/4] libxl: support hotplug USB host device

2016-05-20 Thread Joao Martins
On 05/19/2016 09:14 AM, Chunyan Liu wrote: > Support hot attach/detach a USB host device to guest. > Curretnly libxl only supports xen PV guest, and only > supports specifying USB host device by 'bus number' > and 'device number'. > > For example: > usb.xml: > > > > >

[libvirt] [PATCH V2 2/4] libxl: support hotplug USB host device

2016-05-19 Thread Chunyan Liu
Support hot attach/detach a USB host device to guest. Curretnly libxl only supports xen PV guest, and only supports specifying USB host device by 'bus number' and 'device number'. For example: usb.xml: #xl attach-device dom usb.xml #xl detach-device dom usb.xml