Re: [libvirt] [PATCH V2 2/4] src/xenconfig: Xen-xl parser

2014-10-03 Thread Jim Fehlig
David kiarie wrote: Hmm, any consensus on this? I looked at coreutils following Eric's suggestion, but didn't notice any use of flex. I went back to the automake documented approach [1] and peeked at the resulting generated files. src/Makefile.in contains LEX_OUTPUT_ROOT = lex.yy

Re: [libvirt] [PATCH V2 2/4] src/xenconfig: Xen-xl parser

2014-10-02 Thread David kiarie
Hmm, any consensus on this? On Fri, Sep 12, 2014 at 4:17 PM, Eric Blake ebl...@redhat.com wrote: On 09/11/2014 06:14 PM, Jim Fehlig wrote: But also as mentioned before, I can't figure out how to convince automake to tell flex to generate the header file as well as the .c file. Eric, do you

Re: [libvirt] [PATCH V2 2/4] src/xenconfig: Xen-xl parser

2014-09-12 Thread David Kiarie
On Thu, Sep 11, 2014 at 06:14:12PM -0600, Jim Fehlig wrote: Kiarie Kahurani wrote: Introduce a xen xl parser [...] diff --git a/configure.ac b/configure.ac index f93c6c2..0daf411 100644 --- a/configure.ac +++ b/configure.ac @@ -2177,6 +2177,13 @@ if test -z $PERL; then

Re: [libvirt] [PATCH V2 2/4] src/xenconfig: Xen-xl parser

2014-09-12 Thread Eric Blake
On 09/11/2014 06:14 PM, Jim Fehlig wrote: But also as mentioned before, I can't figure out how to convince automake to tell flex to generate the header file as well as the .c file. Eric, do you have any experience with automake and flex? The following thread makes it sound as though

Re: [libvirt] [PATCH V2 2/4] src/xenconfig: Xen-xl parser

2014-09-11 Thread Jim Fehlig
Kiarie Kahurani wrote: Introduce a xen xl parser [...] diff --git a/configure.ac b/configure.ac index f93c6c2..0daf411 100644 --- a/configure.ac +++ b/configure.ac @@ -2177,6 +2177,13 @@ if test -z $PERL; then AC_MSG_ERROR([Failed to find perl.]) fi +AC_PROG_LEX +if

[libvirt] [PATCH V2 2/4] src/xenconfig: Xen-xl parser

2014-09-10 Thread Kiarie Kahurani
Introduce a xen xl parser This parser allows for users to convert the new xl disk format and spice graphics config to libvirt xml format and vice versa.Regarding the spice graphics config, the code is pretty much straight forward For the disk {formating, parsing} this parser takes care of the new