Re: [libvirt] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Michael S. Tsirkin
On Wed, Jul 22, 2015 at 01:53:14PM +0200, Paolo Bonzini wrote: > > > On 22/07/2015 13:46, Daniel P. Berrange wrote: > > IIUC, the SCSI passthrough feature for virtio-blk is enabled by > > setting the 'scsi=on' property on the virtio-blk device, which is > > exposed by libvirt with XML: > > > >

Re: [libvirt] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Paolo Bonzini
On 22/07/2015 13:46, Daniel P. Berrange wrote: > IIUC, the SCSI passthrough feature for virtio-blk is enabled by > setting the 'scsi=on' property on the virtio-blk device, which is > exposed by libvirt with XML: > > > > > > > > (For use with virtio-scsi you'd just

Re: [libvirt] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Daniel P. Berrange
On Wed, Jul 22, 2015 at 01:40:25PM +0200, Paolo Bonzini wrote: > > > On 22/07/2015 12:19, Michael S. Tsirkin wrote: > > > > SCSI passthrough was no longer supported in virtio 1.0, so this patch > > > > fail the get_features() when both 1.0 and scsi is set. And also only > > > > advertise VIRTIO_B